Re: [PATCH 2/2] pretty: use fmt_output_email_subject()

From: Junio C Hamano <gitster@pobox.com>
Date: Mar 1, 2017, 19:38 UTC
Message-ID: <CAPc5daUyu_=5GeGqBAG_KvkZFE_0oD6Wa_HhoRQwZ2ANUwOF+Q@mail.gmail.com>
In-Reply-To: <20170301193210.tgvnjgc2hfaeebqf@sigill.intra.peff.net>

On Wed, Mar 1, 2017 at 11:32 AM, Jeff King <peff@peff.net> wrote:

Show 5 quoted lines

> I would think that future callers would just need to provide a dummy
> pp->rev. I guess that logic could be pushed down into
> fmt_output_email_subject(), so that it skips looking at
> opt->subject_prefix, etc, when "opt" is NULL, and just hits the
> "Subject:" case arm.

The "flexibility" I was wondering about is that the current .subject can point at any caller-supplied string, not "Subject:".