Re: [PATCH 1/1] git-compat-util.h: drop the `PRIuMAX` definition
- From
Carlo Arenas <carenas@gmail.com>
- Date
- Nov 24, 2019, 17:40 UTC
- Message-ID
- <CAPUEspjAjR+QojRbC8dkoj=9adAKEv4StYYiy6hFmbMwQZ7CNw@mail.gmail.com>
- In-Reply-To
- <20191124170643.GA16907@sigill.intra.peff.net>
On Sun, Nov 24, 2019 at 9:11 AM Jeff King <peff@peff.net> wrote:
> > We do sometimes get portability reports more than a year after the > problem was introduced. But I think this one is pretty safe. PRIuMAX is > in C99, and we've been picking up other C99-isms without complaint.
I think the problem might come from places where the default compiler is still not C99 by default (ex: old CentOS) and any other places using gcc < 5 which is less ancient
Carlo