Re: [PATCH] makefile: teach git about NO_MSGFMT (as supported in GUI and gitk)

From: Carlo Arenas <carenas@gmail.com>
Date: Sep 3, 2021, 01:54 UTC
Message-ID: <CAPUEspj8gwpBNZRqJWgoUG8ouxnMd=SMtoH=z+8AR12+f+j5_g@mail.gmail.com>
In-Reply-To: <nycvar.QRO.7.76.6.2109021730040.55@tvgsbejvaqbjf.bet>

On Thu, Sep 2, 2021 at 8:32 AM Johannes Schindelin <Johannes.Schindelin@gmx.de> wrote:

Show 14 quoted lines

> On Thu, 2 Sep 2021, Carlo Marcelo Arenas Belón wrote:
>
> > NO_MSGFMT can be used to indicate there is no msgfmt available, so
> > make git recognize that and avoid failing to build while trying to
> > generate i18n files.
> >
> > while at it, refactor the change introduced in 4348824059
> > (artifacts-tar: respect NO_GETTEXT, 2021-07-04) with something as
> > functional but shorter.
>
> To me, this commit message is not really related to the diff, which
> essentially only adds a code comment and then has the only functional
> change that _prevents_ `POFILES` and `MOFILES` from being set to empty
> values when `NO_MSGFMT` is set.

correct, except that they should be empty already since nothing has set them and therefore the end result is the same. I should have mentioned I tracked back the conversation for this and even the github issue about it (that I can't find anymore) to make sure it wouldn't introduce a regression.

< I am therefore quite puzzled how that diff is supposed to achieve anything

> that is described in the commit message (how does this "make git recognize
> that"?).

It does not, which is on the (on an unrelated but touching the same lines issue), which I am starting to suspect I shouldn't use anymore; apologies for the noise.

Carlo