Re: [PATCH] send-email: clarify dual-mode behavior
- From
Carlo Arenas <carenas@gmail.com>
- Date
- Sep 24, 2021, 18:55 UTC
- Message-ID
- <CAPUEspj0y04wwG3cjA-AGXc5AAibYGkEUq-wr0B66+hLrf7_6w@mail.gmail.com>
- In-Reply-To
- <xmqq35ptx3l5.fsf@gitster.g>
On Fri, Sep 24, 2021 at 10:53 AM Junio C Hamano <gitster@pobox.com> wrote:
Show 5 quoted lines
> > > +'git send-email' [<options>] <file|directory>... > > +'git send-email' [<options>] <revision range> > > ... this is not improving Thiago's [3/3], I suspect.
I think it does; after all, the original (which I know you proposed) did confuse Bagas who thought it might be missing the tagging of being optional.
The other reasons why this might be better are : * because of the points and examples you provided, a vague [<options>] is better than something that might imply all options taken from format-patch make sense here, which IMHO might be difficult to understand as logical to you as an experienced user. * avoids "promoting" this mode, which is known to be problematic as it could lead to patch bombs without the proper review. it might even be worth adding mentions to --compose or --annotate to avoid that.
Carlo