git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] grep: under --debug, show whether PCRE JIT is enabled

From
Carlo Arenas <carenas@gmail.com>
Date
Aug 26, 2019, 14:42 UTC
Message-ID
<CAPUEspivEfc82ZM=VaUA_sYhQbz+GtoOODVZK2i9LcCkmHq=Sg@mail.gmail.com>
In-Reply-To
<nycvar.QRO.7.76.6.1908261626450.46@tvgsbejvaqbjf.bet>

On Mon, Aug 26, 2019 at 7:29 AM Johannes Schindelin <Johannes.Schindelin@gmx.de> wrote:

Show 10 quoted lines
>
> On Sat, 24 Aug 2019, Carlo Arenas wrote:
>
> > On Mon, Aug 19, 2019 at 3:23 PM Junio C Hamano <gitster@pobox.com> wrote:
> > >
> > > There may be others I am missing.
> >
> > should we still support PCRE1?
>
> While Git for Windows has no problem to just drop PCRE1 support,

FWIW I don't want to drop PCRE1 support, I was not advocating for it, but in the contrary trying to find a way to keep it working as best as possible until we really can't.

Show 7 quoted lines
> I would
> like to take a longer road in Git. Like, deprecate it first (I don't
> know how to do that effectively, though, as packagers usually ignore
> compile warnings, maybe we need to add a Makefile knob
> YES_I_WANT_TO_BUILD_WITH_PCRE1_INSTEAD_OF_PCRE2 and
> YES_I_WILL_STATE_MY_REASONS_ON_THE_GIT_MAILING_LIST or something like
> that).

FWIW e6c531b808 (Makefile: make USE_LIBPCRE=YesPlease mean v2, not v1, 2018-03-11) put a "deprecattion" warning in the Makefile by Ævar, but last time this was discussed[1] Junio made an IMHO sound argument for why that should be removed instead but ab/pcre-jit-fixes and UTF-8 validation are likely to make that more difficult (even if it is a mostly self inflicted wound AFAIK)

Carlo
[1] https://public-inbox.org/git/xmqqlg4xkh28.fsf@gitster-ct.c.googlers.com/
Previous: Johannes SchindelinNext: Junio C Hamano
Message 5 of 8 in “grep: under --debug, show whether PCRE JIT is enabled”
  1. grep: under --debug, show whether PCRE JIT is enabledBeat Bolli, Aug 18, 2019
  2. Junio C HamanoAug 19, 2019
  3. Carlo ArenasAug 24, 2019
  4. Johannes SchindelinAug 26, 2019
  5. Carlo ArenasAug 26, 2019
  6. Junio C HamanoAug 26, 2019
  7. Carlo ArenasAug 26, 2019
  8. Junio C HamanoAug 27, 2019

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.