Re: possible bug with commit-graph causing git to fork bomb (was Re: [External Mail]Re: Git fork process infinitely and never stop)

From: Carlo Arenas <carenas@gmail.com>
Date: Jul 9, 2022, 06:39 UTC
Message-ID: <CAPUEspiP=U+pBYm3tx1wPc46He=5WKkdFYCr-58a-UfhAD+PUg@mail.gmail.com>
In-Reply-To: <20220709005227.82423-1-hanxin.hx@bytedance.com>

On Fri, Jul 8, 2022 at 5:52 PM Han Xin <hanxin.hx@bytedance.com> wrote:

Show 18 quoted lines

>
> > > To be a supplement.
> > > If I delete .git/objects/info/commit-graph,  everything works well As well as fetch with `-c core.commitGraph=false`
> >
> > This would seem to indicate that something in the repository might be
> > triggered by the commit-graph code.
> >
> > > if I execute `git fetch --filter=blob:none --quiet --progress miui --prune --tags +refs/heads/*:refs/remotes/miui/* +refs/heads/miui13-s-thor-vendor-stable:refs/remotes/miui/miui13-s-thor-vendor-stable`  on version 2.25.1. It just throw error rather than infinite loop, like this youtube video "https://www.youtube.com/watch?v=qvYTvVRE0FU&feature=youtu.be"
> >
> > maybe a regression?
> >
> > Carlo
>
> I looks like the same issue I reported in [1], and we can see the fixup
> in [2].
>
> 1. https://lore.kernel.org/git/20220612161707.21807-1-chiyutianyi@gmail.com/
> 2. https://lore.kernel.org/git/cover.1656593279.git.hanxin.hx@bytedance.com/

Indeed; and it is already integrated through hx/lookup-commit-in-graph-fix and merged all the way to "next", which would likely become 2.38 sometime soon.

程洋,

if you could build a new git version based on next and confirm it solves your problem, it would help us all.

Alternative can get that single "one line" patch[1] and integrate it on top of the git version you are using.

Carlo

[1] https://lore.kernel.org/git/96d4bb71505d87ed501c058bbd89bfc13d08b24a.1656593279.git.hanxin.hx@bytedance.com/