Re: cb/pedantic-build-for-developers, POSIX-but-not-C99 and -Wno-pedantic-ms-format

From: Carlo Arenas <carenas@gmail.com>
Date: Sep 21, 2021, 10:10 UTC
Message-ID: <CAPUEspiBP+4Ac4O5ZRTK0N+8PhHeewksrhL=x8TcswrvnS1JOw@mail.gmail.com>
In-Reply-To: <87lf3q9u6b.fsf@evledraar.gmail.com>

>     -       strbuf_addf(&fmt, "%%s%%s%%s-%%0%1$lud.%%0%1$lud-%%s-%%s-%%s",
>     -                   (unsigned long)tmp.len);
>     +       strbuf_addf(&fmt, "%%s%%s%%s-%%0%lud.%%0%lud-%%s-%%s-%%s",
>     +                   (unsigned long)tmp.len, (unsigned long)tmp.len);

The C standard version seems simpler to me, so I would say this was a good outcome overall.

Show 5 quoted lines

> I may be wrong, but I believe that construct is widely portable, we
> don't use it in the main source, but in the po/ files (so anything that
> uses git + gettext tests for this already):
>
>     git grep -P '%\d+\$' -- po

It is not part of ANY C standard, so it will just print gibberish in systems that don't carry this extension.

FWIW is not supported in Windows, which probably explains why they don't carry the po files.

Carlo