Re: [RFC PATCH] grep: allow for run time disabling of JIT in PCRE

From: Carlo Arenas <carenas@gmail.com>
Date: Jul 29, 2019, 00:09 UTC
Message-ID: <CAPUEsphhsbdeutJ8=XrBx-y0shf+64O9o55AeQBhnXYso_1PyQ@mail.gmail.com>
In-Reply-To: <20190728235427.41425-1-carenas@gmail.com>

On Sun, Jul 28, 2019 at 4:54 PM Carlo Marcelo Arenas Belón <carenas@gmail.com> wrote:

Show 13 quoted lines

> @@ -125,6 +126,12 @@ int grep_config(const char *var, const char *value, void *cb)
>                 return 0;
>         }
>
> +       if (!strcmp(var, "pcre.jit")) {
> +               int is_bool;
> +               opt->pcre_jit = git_config_bool_or_int(var, value, &is_bool);
> +               return 0;
> +       }
> +
>         if (!strcmp(var, "color.grep"))
>                 opt->color = git_config_colorbool(var, value);
>         if (!strcmp(var, "color.grep.match")) {

using git_config_bool_or_int, as I am hoping a future version will use a third value (maybe -1) to indicate JIT will be tried first, but then the interpreter will be used in case JIT is not available (as recommended in PCRE)

not sure also about the right name and where to document this flag, as this is not only restricted to the grep subcommand and the issue it is working around will be also relevant for log (including pickaxe)

Carlo