Re: [PATCH 1/5] grep: stop modifying buffer in strip_timestamp
- From
Carlo Arenas <carenas@gmail.com>
- Date
- Sep 21, 2021, 05:18 UTC
- Message-ID
- <CAPUEsphSyZB-vtubjYhN_5Gy3Zv0HQ=fH=+G8kMYzJyrOLXPxQ@mail.gmail.com>
- In-Reply-To
- <YUlVsLkFGRfRqpKG@coredump.intra.peff.net>
On Mon, Sep 20, 2021 at 9:09 PM Jeff King <peff@peff.net> wrote:
Show 6 quoted lines
> @@ -971,7 +966,7 @@ static int match_one_pattern(struct grep_pat *p, char *bol, char *eol,
> switch (p->field) {
> case GREP_HEADER_AUTHOR:
> case GREP_HEADER_COMMITTER:
> - saved_ch = strip_timestamp(bol, &eol);
> + strip_timestamp(bol, &eol);Why not something like (plus added error handling, even if it seems the original didn't have them)?
eol = strrchr(bol, '>');
Carlo