Re: [PATCH] Use mingw.h declarations for gmtime_r/localtime_r on msys2
- From
Carlo Arenas <carenas@gmail.com>
- Date
- Oct 5, 2021, 07:12 UTC
- Message-ID
- <CAPUEspgLwLxavP3bC9OEJQTphoemQ+jxv+9Nkcvbf51uaBEpww@mail.gmail.com>
- In-Reply-To
- <20211005063936.588874-1-mh@glandium.org>
On Mon, Oct 4, 2021 at 11:57 PM Mike Hommey <mh@glandium.org> wrote:
> A possible alternative fix would be to e.g. add `#define _POSIX_C_SOURCE > 200112L` to git-compat-util.h and add `ifndef __MINGW64_VERSION_MAJOR` > around the definitions of `gmtime_r` and `localtime_r` in > compat/mingw.c, since, after all, they are available there.
something like that was merged to "main"[1] a few months ago, would that work for you?
Carlo
[1] https://github.com/git-for-windows/git/commit/9e52042d4a4ee2d91808dda71e7f2fdf74c83862