Re: [PATCH] range-diff: fix some 'hdr-check' and sparse warnings

From: Carlo Arenas <carenas@gmail.com>
Date: Jul 13, 2019, 22:22 UTC
Message-ID: <CAPUEspgD8E02FcNvBx96neGEejdqMDWoH8NgpsHyGPo_KM09FA@mail.gmail.com>
In-Reply-To: <xmqq1rytpqse.fsf@gitster-ct.c.googlers.com>

On Sat, Jul 13, 2019 at 2:29 PM Junio C Hamano <gitster@pobox.com> wrote:

>
> I wish if we could say
>
>         struct patch patch = {};

that is actually a GNU extension that is supported by gcc and clang (at least) and that sparse also recognizes as valid; it is also valid C++ so it might be even supported by MSVC.

it will obviously trigger warnings if using pedantic mode and is IMHO not worth the hassle to maintain in a portable codebase like git, but also wish could be added to C2X

Carlo