Re: [PATCH v5 3/3] send-email docs: add format-patch options

From: Carlo Arenas <carenas@gmail.com>
Date: Sep 24, 2021, 06:56 UTC
Message-ID: <CAPUEspg23UqzrVSFb9KYY9k0bcp2wo4kfNbjE_ma6j4fM1=gNA@mail.gmail.com>
In-Reply-To: <4c415fd4-a74e-5eb0-061e-39185be623ca@gmail.com>

On Thu, Sep 23, 2021 at 11:19 PM Bagas Sanjaya <bagasdotme@gmail.com> wrote:

Show 21 quoted lines

>
> On 24/09/21 11.53, Carlo Arenas wrote:
> > no; as Junio explained [1] this omission is intentional while the
> > rev-list options that
> > got cut to make space are not and are more relevant.
> >
> > IMHO leaving [<options>] to imply ALL options (that also include diff
> > options, for example) is better
>
> Quoting what you linked:
>
> > The program works in two majorly different modes.  It either takes
> >
> >  * message files that are already proof-read and copy-edited from
> >    the filesystem and sends them out, or
> >
> >  * format-patch options to generate message files out of the commits
> >    and send them out without any proofreading.
>
> I think we need to again modify SYNOPSIS and DESCRIPTIONS to highlight
> above fact:

Bagas,

This is much better; can you SOB and help Thiago import it into his tree so it can be included in the next reroll?

Thiago,

Let's wait a little while to collect more feedback on patch2 before sending it, though

Carlo