Re: [Outreachy] Potential intern.

From: Usman Akinyemi <usmanakinyemi202@gmail.com>
Date: Oct 5, 2024, 16:41 UTC
Message-ID: <CAPSxiM_fTMCzXg3OrcbJrn=UskyCaR3D=xgR4d6PrnnAdoYcCQ@mail.gmail.com>
In-Reply-To: <Zv0-Wv03hSea_Tje@pks.im>

Hi Patrick,

Following this, I have gone through [1], [2] and some other resources.

I was able to get potential three interesting MiniProject which I can work on. I have also checked through the mailing list to ensure no one is working on any of the particular file. As advised, I am sending this just to be sure if it’s worth doing and if it’s appropriate for a miniproject. I am sending three MiniProjects so I can have one to work with in case any of them is not appropriate.

1. Use test_path_is_* functions in test scripts
An approved sample -
https://lore.kernel.org/git/20240304095436.56399-2-shejialuo@gmail.com/

Two email threads of discussion and feedback from maintainers.

https://lore.kernel.org/git/CAPig+cR2-6qONkosu7=qEQSJa_fvYuVQ0to47D5qx904zW08Eg@mail.gmail.com/ https://public-inbox.org/git/CAPig+cRfO8t1tdCL6MB4b9XopF3HkZ==hU83AFZ38b-2zsXDjQ@mail.gmail.com/

Two potential test files which I saw that I can work one.

t/t7003-filter-branch.sh

test_expect_success 'test that the file was renamed' ' test D = "$(git show HEAD:doh --)" && ! test -f D.t && test -f doh && test D = "$(cat doh)" '

t/t2003-checkout-cache-mkdir.sh

test_expect_success 'use --prefix=path2/' ' rm -fr path0 path1 path2 && mkdir path2 && git checkout-index --prefix=path2/ -f -a && test -f path2/path0 && test -f path2/path1/file1 && test ! -f path0 && test ! -f path1/file1 ' These two are asserting that if a file exists, it can be changed to test_file_exist

2. Avoid suppressing git’s exit code in test scripts

Sample email thread about the same issue. https://public-inbox.org/git/pull.885.v2.git.git.1603032125151.gitgitgadget@gmail.com/

First file - t/t6050-replace.sh code sample test_expect_success 'replace the author' ' git cat-file commit $HASH2 | grep "author A U Thor" && R=$(git cat-file commit $HASH2 | sed -e "s/A U/O/" | git hash-object -t commit --stdin -w) && git cat-file commit $R | grep "author O Thor" && git update-ref refs/replace/$HASH2 $R && git show HEAD~5 | grep "O Thor" && git show $HASH2 | grep "O Thor" ' Second File - t/t3404-rebase-interactive.sh code sample that needs improvement

test_expect_success 'retain authorship' ' echo A > file7 && git add file7 && test_tick && GIT_AUTHOR_NAME="Twerp Snog" git commit -m "different author" && git tag twerp && git rebase -i --onto primary HEAD^ && git show HEAD | grep "^Author: Twerp Snog" '

3. Modernise test.
Description
https://lore.kernel.org/git/CAPig+cQpUu2UO-+jWn1nTaDykWnxwuEitzVB7PnW2SS_b7V8Hg@mail.gmail.com/
Sample code t/t7611-merge-abort.sh test_expect_success 'Reset index
(but preserve worktree changes)' '
git reset "$pre_merge_head" &&
git diff > actual &&
test_cmp expect actual
'
Thank you as I await your feedback.

On Wed, Oct 2, 2024 at 12:36 PM Patrick Steinhardt <ps@pks.im> wrote:

Show 40 quoted lines

>
> Hi again :)
>
> I've already replied to this email when it reached Phillip and me in
> private and redirected it to the mailing list. So I'll repeat what I've
> said in my reply mail just so that others are aware that I've responded
> to it.
>
> On Wed, Oct 02, 2024 at 07:12:37AM +0000, Usman Akinyemi wrote:
> > Hello, I am Usman Akinyemi from the Outreachy program, I just got
> > selected for the second round contribution stage, I got interested in
> > the git project as it is one of the most important OpenSource
> > projects.
>
> Great, thanks for reaching out to us and thank you for your interest in
> the Git community!
>
> > Also, my skills are aligned with the required skill for the
> > projects and it is related with what I did at systemd where I created
> > a new unit test framework which is now the primary framework used
> > across the project. This development has significantly enhanced
> > testing efficiency by improving error reporting and debugging,
> > streamlining development processes, and increasing the reliability of
> > the software.
> >
> > I hope to learn and contribute meaningful contributions to git.
> >
> > Also, if there is anything I need to learn about, kindly let me know.
> > I really appreciate it.
>
> I would strongly recommend reading through [1] and [2]. They should give
> you some ideas for how the Outreachy application process is designed to
> work in the Git project and lays out the expectation of us mentors.
>
> Let me know in case you have any additional questions!
>
> Patrick
>
> [1]: https://git.github.io/Mentoring-Program-Guide/
> [2]: https://git.github.io/General-Microproject-Information/