Re: [PATCH] t2004: use test_path_is_file instead of test -f

From: Usman Akinyemi <usmanakinyemi202@gmail.com>
Date: Feb 22, 2026, 09:44 UTC
Message-ID: <CAPSxiM8f59DK75BeXXo53A2wRqtxd2wQ-ejpmGTyjnSsVTJFBA@mail.gmail.com>
In-Reply-To: <pull.2049.git.1771694893208.gitgitgadget@gmail.com>

Show 14 quoted lines

>                 test $(cat ../$s1) = tree1asubdir/path5)
> @@ -230,7 +230,7 @@ test_expect_success 'checkout --temp symlink' '
>         test_line_count = 1 actual &&
>         test $(cut "-d  " -f2 actual) = path6 &&
>         p=$(cut "-d     " -f1 actual) &&
> -       test -f $p &&
> +       test_path_is_file $p &&
>         test $(cat $p) = path7
>  '
>
>
> base-commit: 67ad42147a7acc2af6074753ebd03d904476118f
> --
> gitgitgadget

I reviewed this patch, it looks good to me.