git/list[1] front-page[2] threads[3] people[4] search[5] about
 

How to implement the "amend!" commit ?

From
Charvi Mendiratta <charvi077@gmail.com>
Date
Jan 13, 2021, 01:15 UTC
Message-ID
<CAPSFM5f+cm87N5TO3V+rJvWyrcazybNb_Zu_bJZ+sBH4N4iyow@mail.gmail.com>
In-Reply-To
<CAPSFM5c2iqBn8_Dih2id7q6RRp0q=vfCSVUHDE5AOXZ8z3Ko9w@mail.gmail.com>
Hi Everyone,

Implementing "amend!" commit would be an alternative to the fixup!/squash! commit that addresses the issue as opened here[1]. Also the related patches[2], adds the options to `fixup` command in interactive rebase and supports the "amend!" commit upon `--autosquash`. Next, after discussing with Phillip and Christian, there could be 3 possibilities to implement the "amend!" commit (UI):

Firstly, the `--fixup=<commit>` to have option like, `--fixup=reword/amend:<commit>`

So, `git commit --fixup` can have 3 options:

a) `--fixup=<commit>`, work as of now, make fixup! commit. b) `--fixup=amend:<commit>`, make "amend!" commit, takes changes and also opens the editor for a new message (Here it adds a new message to amend! commit's message body and upon autosquash it will fixup up the content and reword the original commit message i.e replaces the original commit message with the "amend!" commit's message). c) `--fixup=reword:<commit>`, makes (empty) "amend!" commit, do not take changes and open the editor for a new message(Here, upon autosquash it will just reword the original commit message).

Secondly, As an alternative to above, we can use `--fixup=<commit> --amend` and `--fixup=<commit> --reword`.

Next, To use only, `--fixup=<commit> --edit` to make the "amend!" commit.

Also as discussed earlier[3] we are avoiding the use of additional options like `git commit --amend=<commit>` inorder to avoid confusion of doing similar things in different ways. So, I wonder which could be the best way to proceed with or if any other way to implement "amend!" commit ?

Thanks and Regards, Charvi

[1] https://github.com/gitgitgadget/git/issues/259 [2] https://lore.kernel.org/git/20210108092345.2178-1-charvi077@gmail.com/ [3] https://lore.kernel.org/git/95cc6fb2-d1bc-11de-febe-c2b5c78a6850@gmail.com/

Next: Taylor Blau
Message 1 of 15 in “How to implement the "amend!" commit ?”
  1. Charvi MendirattaJan 13, 2021
  2. Taylor BlauJan 13, 2021
  3. Taylor BlauJan 13, 2021
  4. Charvi MendirattaJan 14, 2021
  5. Phillip WoodJan 14, 2021
  6. Taylor BlauJan 14, 2021
  7. Phillip WoodJan 15, 2021
  8. Martin ÅgrenJan 15, 2021
  9. Junio C HamanoJan 14, 2021
  10. Phillip WoodJan 15, 2021
  11. Junio C HamanoJan 15, 2021
  12. Charvi MendirattaJan 17, 2021
  13. Junio C HamanoJan 17, 2021
  14. Charvi MendirattaJan 17, 2021
  15. Charvi MendirattaJan 15, 2021

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.