Re: [PATCH] apply: support case-only renames in case-insensitive filesystems

From: Tao Klerks <tao@klerks.biz>
Date: Jun 18, 2022, 15:34 UTC
Message-ID: <CAPMMpohkEDwdDoDZ9nQkD71FbDZU6a9Ut0WLUSqBp-oqFLOr5g@mail.gmail.com>
In-Reply-To: <xmqqiloyn6j5.fsf@gitster.g>

On Sat, Jun 18, 2022 at 2:45 AM Junio C Hamano <gitster@pobox.com> wrote:

Show 22 quoted lines

>
> Tao Klerks <tao@klerks.biz> writes:
>
> >  I assumed that
> > both case-sensitive and case-insensitive code paths would be tested by
> > the complete CI suite.
>
>
> When the system I am primary owrking on is case sensitive, it is
> always nice to be able to discover that I broke something on case
> INsensitive system before I conclude my WIP into a commit and throw
> it at CI.  We may have to case-insensitively treat the paths in the
> index in order to match what the working tree would do to make "git
> checkout -- <path>" work case-insentively, and doing in-index-only
> mode of operation with core.ignorecase=yes on case-sensitive system
> may be a way to "emulate" some of the requirement case-insentive
> systems have with these "-c core.ignorecase" trick, but of course
> not all scenarios can be tested without being on case-insensitive
> systems.
>
> So we need both, I think.
>

Understood, makes sense, thank you.

I made some changes that seem to resolve the regression that I had previously noted, but I'm not sure the approach makes sense, it feels like there must be a better way. I will submit an RFC series at this point I think.