Re: [GSoC][RFC][Proposal v2] Move existing tests to a unit testing framework
- From
Christian Couder <christian.couder@gmail.com>
- Date
- Mar 26, 2024, 09:32 UTC
- Message-ID
- <CAP8UFD3xiGH72BRdQ=76npUKp8pCF+cLXoNYkUFUNKyejWDSAg@mail.gmail.com>
- In-Reply-To
- <20240321202218.13648-1-shyamthakkar001@gmail.com>
Hi Ghanshyam,
On Thu, Mar 21, 2024 at 9:22 PM Ghanshyam Thakkar <shyamthakkar001@gmail.com> wrote:
Show 7 quoted lines
> @@ -294,8 +325,28 @@ have not setup the blog yet, it will be at: > ----Availability---- > > My current semester ends on 30th April and my exam/viva is tentatively on 7th > -May. After that I have freed my summer for GSoC, therefore I will be able to > -give a minimum of 35-40 hours per week. > +Mayand I will graduate after the results are out in June. Therefore I will be
s/Mayand/May and/
> +able to give a minimum of 35-40 hours per week after 7th May as I have not taken > +up any responsibilities in the summer for the purpose of GSoC.
Show 18 quoted lines
> +----Stretch Goals---- > + > +These goals may not be achieved during the GSoC period, however, these may come > +in handy if the migration is done ahead of the schedule or it is determined that > +the number of tests that need to be migrated are not sufficient to cover the > +allocated GSoC period further down the line. These can also be done after the > +GSoC period. (Note that these are just personal observations/ideas and may not > +be accepted by mentors, hence '_Stretch_ Goals'.) > +- Enhancement of the unit testing library. An example of the need of doing this > + would be t-ctype, which bypasses top-level macros such as TEST(), in favor of > + custom logic with the use of internal helper functions. > +- Add more helper functions in the unit testing library such as handling and use > + of parameters defined by environment variables (which I personally faced in > + implementing t-oidarray.) I am sure there are other such utilities which might > + be worthwhile. > +- Adding support for performance related testing through unit tests. > +- Working in other areas of the codebase not related to unit testing or doing > + other tasks as specified by mentors.
This makes me think that it would be nice if you or others interested in the "Move existing tests to a unit testing framework" project could review Luma's patches that haven't been reviewed and merged yet. See the "Key Achievements" in https://lumap.gitlab.io/posts/outreachy-internship-conclusion for pointers to the patches.
Thanks for updating your proposal anyway. Except for the typo above, all the changes LGTM.