git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v7 03/12] for-each-ref: change comment in ref_sort

From
Christian Couder <christian.couder@gmail.com>
Date
Jun 12, 2015, 19:49 UTC
Message-ID
<CAP8UFD3nsxX0XEVwxdMBRR8OQDu=ary6Bm2AD7wprAU0BC8tXA@mail.gmail.com>
In-Reply-To
<557B2516.7020609@gmail.com>
On Fri, Jun 12, 2015 at 8:29 PM, Karthik Nayak <karthik.188@gmail.com> wrote:
Show 19 quoted lines
> On 06/12/2015 11:34 PM, Junio C Hamano wrote:
>>
>> Karthik Nayak <karthik.188@gmail.com> writes:
>>
>>>> What change since 9f613dd do you have in mind, exactly, though?
>>>
>>>
>>> Well initially the atoms were indexed into used_atom array, which
>>> later was removed. Hence the comment becomes obsolete.
>>
>>
>> Later in which commit?  In builtin/for-each-ref.c in the version
>> after applying patches 1-3 of this series on top of master, I still
>> see used_atom[] array there, so...?
>>
>
> Uh! My bad.
> Ignore this! I think I got confused, On having a look now that patch is
> not needed. Sorry.

I think it is needed later when "struct ref_sort" is moved into ref-filter.h, because then the used_atom[] array is not moved.

So either:
1) you update the comment when you move "struct ref_sort" into
ref-filter.h, but then the downside is that there is not only code
movement in the patch that moves "struct ref_sort" into ref-filter.h,
or
2) you explain that, as "struct ref_sort" will be moved later while
the used_atom[] array will not be moved, the direct connection between
the comment and used_atom[] will be broken, and you need to prepare
for that because you want to avoid solution 1) as you want only code
movement when moving "struct ref_sort" into ref-filter.h.

Hope this helps, Christian.

Previous: Karthik NayakNext: Junio C Hamano
Message 9 of 32 in “Create ref-filter from for-each-ref”
  1. 0/12 Create ref-filter from for-each-refKarthik Nayak, Jun 11, 2015
  2. 01/12 for-each-ref: extract helper functions out of grab_single_ref()Karthik Nayak, Jun 11, 2015
  3. 02/12 for-each-ref: clean up codeKarthik Nayak, Jun 11, 2015
  4. 03/12 for-each-ref: change comment in ref_sortKarthik Nayak, Jun 11, 2015
  5. Junio C HamanoJun 12, 2015
  6. Karthik NayakJun 12, 2015
  7. Junio C HamanoJun 12, 2015
  8. Karthik NayakJun 12, 2015
  9. Christian CouderJun 12, 2015
  10. Junio C HamanoJun 12, 2015
  11. karthik nayakJun 12, 2015
  12. 04/12 for-each-ref: rename 'refinfo' to 'ref_array_item'Karthik Nayak, Jun 11, 2015
  13. 05/12 for-each-ref: introduce new structures for better organisationKarthik Nayak, Jun 11, 2015
  14. Matthieu MoyJun 11, 2015
  15. Karthik NayakJun 11, 2015
  16. Matthieu MoyJun 11, 2015
  17. Karthik NayakJun 11, 2015
  18. Matthieu MoyJun 11, 2015
  19. 06/12 for-each-ref: introduce 'ref_array_clear()'Karthik Nayak, Jun 11, 2015
  20. 07/12 for-each-ref: rename some functions and make them publicKarthik Nayak, Jun 11, 2015
  21. 08/12 for-each-ref: rename variables called sort to sortingKarthik Nayak, Jun 11, 2015
  22. 09/12 ref-filter: add 'ref-filter.h'Karthik Nayak, Jun 11, 2015
  23. 10/12 ref-filter: move code from 'for-each-ref'Karthik Nayak, Jun 11, 2015
  24. 11/12 for-each-ref: introduce filter_refs()Karthik Nayak, Jun 11, 2015
  25. Matthieu MoyJun 11, 2015
  26. Karthik NayakJun 11, 2015
  27. Junio C HamanoJun 12, 2015
  28. 11/12 for-each-ref: introduce filter_refs()Karthik Nayak, Jun 11, 2015
  29. 12/12 ref-filter: make 'ref_array_item' use a FLEX_ARRAY for refnameKarthik Nayak, Jun 11, 2015
  30. Junio C HamanoJun 12, 2015
  31. Karthik NayakJun 12, 2015
  32. Matthieu MoyJun 11, 2015

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.