Re: [PATCH 1/3] revision: clarify a 'return NULL' in get_reference()

From

Christian Couder <christian.couder@gmail.com>

Date

Feb 1, 2024, 16:49 UTC

Message-ID

<CAP8UFD3ka-HyUAdJ8RTfMt1HPmp5nQ3EKK2soE1Vjn+7C5OmMA@mail.gmail.com>

In-Reply-To

<CAPig+cSNM0VJZ5SpvazY5T6rFvXuoTdfgD5J5f36PW4iW7xLVA@mail.gmail.com>

On Thu, Feb 1, 2024 at 3:53 PM Eric Sunshine <sunshine@sunshineco.com> wrote:

>
> On Thu, Feb 1, 2024 at 6:58 AM Christian Couder
> <christian.couder@gmail.com> wrote:
> > In general when we know a pointer variable is NULL, it's clearer to
> > explicitely return NULL than to return that variable.
>
> s/explicitely/explicitly/

[...]

> > Let's make the code clearer and more uniform by also explicitely
> > returning NULL when 'revs->ignore_missing' is true.
>
> s/explicitely/explicitly/