Re: [PATCH v2] t: make many tests depend less on the refs being files

From: Christian Couder <christian.couder@gmail.com>
Date: May 25, 2018, 11:21 UTC
Message-ID: <CAP8UFD3hqQ_F0yafS6v6GWvN7zYomM-=fsZKotP9r-9Xc4qJ+g@mail.gmail.com>
In-Reply-To: <615f57ad-7591-128a-0c42-660312d34ca2@alum.mit.edu>

On Fri, May 25, 2018 at 10:48 AM, Michael Haggerty <mhagger@alum.mit.edu> wrote:

Show 18 quoted lines

> On 05/23/2018 07:25 AM, Christian Couder wrote:
>>
>> diff --git a/t/t1401-symbolic-ref.sh b/t/t1401-symbolic-ref.sh
>> index 9e782a8122..a4ebb0b65f 100755
>> --- a/t/t1401-symbolic-ref.sh
>> +++ b/t/t1401-symbolic-ref.sh
>> @@ -65,7 +65,7 @@ reset_to_sane
>>  test_expect_success 'symbolic-ref fails to delete real ref' '
>>       echo "fatal: Cannot delete refs/heads/foo, not a symbolic ref" >expect &&
>>       test_must_fail git symbolic-ref -d refs/heads/foo >actual 2>&1 &&
>> -     test_path_is_file .git/refs/heads/foo &&
>> +     git rev-parse --verify refs/heads/foo &&
>>       test_cmp expect actual
>>  '
>>  reset_to_sane
>
> Should t1401 be considered a backend-agnostic test, or is it needed to
> ensure that symbolic refs are written correctly in the files backend?

I don't know. And I am ok to go either way. Another possibility would be to split in two parts.