Re: [PATCH 0/6] receive-pack: quarantine pushed objects

From: Christian Couder <christian.couder@gmail.com>
Date: Oct 2, 2016, 09:20 UTC
Message-ID: <CAP8UFD3Y1du+L9DRgz01wgbsCYiebu2DgyePH41MaDhjV24oHw@mail.gmail.com>
In-Reply-To: <20160930193533.ynbepaago6oycg5t@sigill.intra.peff.net>

On Fri, Sep 30, 2016 at 9:35 PM, Jeff King <peff@peff.net> wrote:

> I've mentioned before on the list that GitHub "quarantines" objects
> while the pre-receive hook runs. Here are the patches to implement
> that.

Great! Thanks for upstreaming these patches!

I wonder if the patch you sent in:

https://public-inbox.org/git/20160816144642.5ikkta4l5hyx6act@sigill.intra.peff.net/

is still useful or not.

Show 12 quoted lines

> The basic problem is that as-is, index-pack admits pushed objects into
> the main object database immediately, before the pre-receive hook runs.
> It _has_ to, since the hook needs to be able to actually look at the
> objects. However, this means that if the pre-receive hook rejects the
> push, we still end up with the objects in the repository. We can't just
> delete them as temporary files, because we don't know what other
> processes might have started referencing them.
>
> The solution here is to push into a "quarantine" directory that is
> accessible only to pre-receive, check_connected(), etc, and only
> move the objects into the main object database after we've finished
> those basic checks.

I guess if we fail the receive-pack because the pack is bigger than receive.maxInputSize, then the "quarantine" directory will also be removed, so the part of the pack that we received before failing the receive-pack will be deleted.

[...]

>     These two patches set that up by letting index-pack and pre-receive
>     know that quarantine path and use it to store arbitrary files that
>     _don't_ get migrated to the main object database (i.e., the log file
>     mentioned above).

It would be nice to have a diffstat for the whole series.

Thanks, Christian.