Re: [GSoC] Convert “git stash” to builtin proposal

From: Christian Couder <christian.couder@gmail.com>
Date: Mar 20, 2018, 22:08 UTC
Message-ID: <CAP8UFD3NKCSN8mVDiCUzvor5uZh4nFCAw4T0zgxpvHLf9AWmyA@mail.gmail.com>
In-Reply-To: <1521576562.2188.10.camel@gmail.com>

Hi,

On Tue, Mar 20, 2018 at 9:09 PM, Paul-Sebastian Ungureanu <ungureanupaulsebastian@gmail.com> wrote:

>
> * Convert function: this step is basically makes up the goal of this
> project.

Could you explain a bit more how you would convert a function? Or could you explain for example how you would convert "git stash list" below?

Show 5 quoted lines

> * Ensure that no regression occurred: considering that there are plenty
> of tests and that I have a good understanding of the function, this
> should be a trivial task.
>
> * Finally write more tests to ensure best code coverage.

Maybe, as Dscho suggested to another potential GSoC student, it would be better to write more tests before converting the function.

Show 7 quoted lines

> # Useful resources
> There has been a lot of progress made in this direction already and I
> believe it will serve of great help. However, from my understanding it
> is not yet mergeable and it requires changes.
>
> https://public-inbox.org/git/20170608005535.13080-1-joel@teichroeb.net/
> T/#m8849c7ce0ad8516cc206dd6910b79591bf9b3acd

Maybe you should Cc the author of this patch series.

Also please notice that the patch series started with adding some tests.

> I am expecting to submit a patch for every command that is converted.
> This way, I have well set milestones and results will be seen as soon
> as possible. Moreover, seeing my contributions getting merged will be a
> huge confidence boost to myself.

Show 5 quoted lines

> Each “convert” phase of the project below is not only about converting
> from Shell to C, but also ensuring that everything is documented, there
> are enough tests and there are no regressions.
>
> 14th May - 20th May             - Convert "git stash list"

For example could you explain a bit more which functions/commands you would create in which file and how you would call them to convert `git stash list`