Re: [PATCH v2 2/2] fast-import: add '--signed-commits=<mode>' option

From: Christian Couder <christian.couder@gmail.com>
Date: Sep 17, 2025, 18:23 UTC
Message-ID: <CAP8UFD3LNnDfc5KDGZUTvbHoMrHxN=m6KjH_c9GbDztpiUNazQ@mail.gmail.com>
In-Reply-To: <aMfw4rboBOemzvr6@pks.im>

On Mon, Sep 15, 2025 at 12:56 PM Patrick Steinhardt <ps@pks.im> wrote:

Show 5 quoted lines

>
> On Mon, Sep 15, 2025 at 12:17:33PM +0200, Christian Couder wrote:
> > On Mon, Sep 15, 2025 at 8:27 AM Patrick Steinhardt <ps@pks.im> wrote:
> > >
> > > On Fri, Sep 12, 2025 at 02:40:42PM +0200, Christian Couder wrote:

Show 13 quoted lines

> > > >
> > > > +             switch (signed_commit_mode) {
> > > > +             case SIGN_ABORT:
> > > > +                     BUG("SIGN_ABORT should be handled before calling parse_one_signature()");
> > > > +                     break;
> > >
> > > Let's be defensive and convert this into a `default:` case so that any
> > > unhandled value will cause a BUG.
> >
> > Ok, maybe something like BUG("invalid signed_commit_mode value %d",
> > signed_commit_mode) then?
>
> Yeah, that should do the job.

In the V3 I just sent, I have changed the switch (...) { ... } but there is a `default: ...` case with the BUG() instruction we discussed. Hopefully it still does the job.

Thanks.