git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 3/3] fast-import: add 'strip-if-invalid' mode to --signed-commits=<mode>

From
Christian Couder <christian.couder@gmail.com>
Date
Nov 12, 2025, 07:25 UTC
Message-ID
<CAP8UFD3G6kn-n1_rXJgcZf1djUE4Ner5xd1YaNr5tz5h8d_Ypw@mail.gmail.com>
In-Reply-To
<xmqqjz00e5ns.fsf@gitster.g>
On Sat, Nov 8, 2025 at 7:32 PM Junio C Hamano <gitster@pobox.com> wrote:
Show 18 quoted lines
>
> Christian Couder <christian.couder@gmail.com> writes:
>
> >  t/t9305-fast-import-signatures.sh  | 118 ++++++++++++++++++++++++++++-
> >  6 files changed, 226 insertions(+), 28 deletions(-)
>
> Unfortunately all these tests that assume that explicit-sha256
> repository as a subdirectory exists would fail when the topic is
> merged to 'seen' and the tree is built without the optional Rust
> support.  This is because brian's f6581e23 (repository: require Rust
> support for interoperability, 2025-10-27) changes a couple of tests
> to require RUST prerequisite.  One of them is what creates the
> explicit-sha256 repository.
>
> I do not think this topic to preserve or strip GPG signatures
> particularly cares about the dual hash interoperability, so can you
> rearrange the tests in this series to avoid crashing with the other
> topic?
I will do that in the v2 I hope I can send soon.
Thanks for telling me about this issue.
Previous: Junio C HamanoNext: Junio C Hamano
Message 6 of 20 in “fast-import: add 'strip-if-invalid' mode to --signed-commits=<mode>”
  1. 0/3 fast-import: add 'strip-if-invalid' mode to --signed-commits=<mode>Christian Couder, Nov 5, 2025
  2. 1/3 fast-import: refactor finalize_commit_buffer()Christian Couder, Nov 5, 2025
  3. 2/3 commit: refactor verify_commit_buffer()Christian Couder, Nov 5, 2025
  4. 3/3 fast-import: add 'strip-if-invalid' mode to --signed-commits=<mode>Christian Couder, Nov 5, 2025
  5. Junio C HamanoNov 8, 2025
  6. Christian CouderNov 12, 2025
  7. Junio C HamanoNov 12, 2025
  8. Junio C HamanoNov 5, 2025
  9. Elijah NewrenNov 8, 2025
  10. Christian CouderNov 12, 2025
  11. Christian CouderNov 12, 2025
  12. Junio C HamanoNov 12, 2025
  13. 0/3 fast-import: add 'strip-if-invalid' mode to --signed-commits=<mode>Christian Couder, Nov 17, 2025
  14. 1/3 fast-import: refactor finalize_commit_buffer()Christian Couder, Nov 17, 2025
  15. 2/3 commit: refactor verify_commit_buffer()Christian Couder, Nov 17, 2025
  16. 3/3 fast-import: add 'strip-if-invalid' mode to --signed-commits=<mode>Christian Couder, Nov 17, 2025
  17. Elijah NewrenNov 17, 2025
  18. Christian CouderNov 18, 2025
  19. Junio C HamanoNov 18, 2025
  20. Elijah NewrenNov 18, 2025

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.