Re: [RFC/PATCH v3 01/16] Add initial external odb support
- From
Christian Couder <christian.couder@gmail.com>
- Date
- Aug 3, 2017, 07:48 UTC
- Message-ID
- <CAP8UFD32uYggO1s3h9Ysqtp5hqDWg3LUkCr5_1LoPBLwY3fXgA@mail.gmail.com>
- In-Reply-To
- <20161130233721.7yqu7pbr2oc53o7v@sigill.intra.peff.net>
On Thu, Dec 1, 2016 at 12:37 AM, Jeff King <peff@peff.net> wrote:
Show 20 quoted lines
> On Wed, Nov 30, 2016 at 03:30:09PM -0800, Junio C Hamano wrote: > >> Christian Couder <christian.couder@gmail.com> writes: >> >> > From: Jeff King <peff@peff.net> >> > >> > Signed-off-by: Christian Couder <chriscool@tuxfamily.org> >> > --- >> >> By the time the series loses RFC prefix, we'd need to see the above >> three lines straightened out a bit more, e.g. a real message and a >> more proper sign-off sequence. > > Actually, I would assume that this patch would go away altogether and > get folded into commits that get us closer to the end state. But I > haven't read the series carefully yet, so maybe it really does work > better with this as a base. > > I am perfectly OK dropping my commit count by one and getting "based on > a patch by Peff" in a cover letter or elsewhere.
Ok I have dropped your commit count and added "Helped-by: Jeff King <peff@peff.net>" in the patches that come from your work.
Thanks!