Re: [PATCH 2/3] perf/aggregate: add --reponame option

From: Christian Couder <christian.couder@gmail.com>
Date: Jan 29, 2018, 07:34 UTC
Message-ID: <CAP8UFD3-sTC+eknu2Vfjx+QX7j3AeDaqMMi8L2LQPuSCn3L7Jw@mail.gmail.com>
In-Reply-To: <CAPig+cR77RTTw3uJAwK3XmmvzE7umv3_7M=NkaDEb=uXyNL4FA@mail.gmail.com>

On Sun, Jan 28, 2018 at 8:57 PM, Eric Sunshine <sunshine@sunshineco.com> wrote:

Show 10 quoted lines

>
> Not a big deal, but the extra indentation (and noisy diff) could be
> avoided like this:
>
>     my $environment;
>     if ($reponame) {
>         $environment = $reponame;
>     } else if (exists ...) {
>         ...as before....
>     }

Ok I will reroll with something like this and also the typo fix suggested by Philip.

Thanks both.