Re: [GSoC][RFC][PROPOSAL v3] Unify ref-filter formats with other --pretty formats
- From
Christian Couder <christian.couder@gmail.com>
- Date
- Mar 24, 2020, 11:18 UTC
- Message-ID
- <CAP8UFD2nVnrudUWtNzq4Lc-zyXPU8r9wjvtnBgVTY4vQxsqLzw@mail.gmail.com>
- In-Reply-To
- <CA+CkUQ__JPsLCkkdHg7gh8J7VvXLA+v2j3NgV6cZAw94if=9mA@mail.gmail.com>
Hi,
On Sun, Mar 22, 2020 at 3:56 PM Hariom verma <hariom18599@gmail.com> wrote:
> I would love to get my proposal reviewed and have suggestions from you all.
Sorry for the late reviews.
[...]
Show 19 quoted lines
> My task is to change formatting logic in pretty.c. Actually, to remove
> the current formatting solution and reuse solution from ref-filter
> (maybe without changing pretty.c logically).
> As Thomas<t.gummerer@gmail.com>
> [suggested](https://public-inbox.org/git/20190331184930.GV32487@hank.intra.tgummerer.com/),
> I’ll start by first looking at what actually needed to be replaced
> (for example by studying the PRETTY FORMATS section in 'man git-log',
> what which verbs you can use in the ref-filter ('man
> git-for-each-ref') to achieve the same thing.
> Then I’ll research how one format is implemented in 'pretty.c', and
> see how a similar thing using the ref-filter is implemented in
> 'ref-filter.c'.
> e.g. the "%(objectname:short) %(contents:subject)" (this is missing
> coloring, but just to get you the idea) is similar to
> '--pretty=oneline'. Now one can try to find how 'oneline' is
> implemented in 'pretty.c', and could translate that to use the
> 'ref-filter' API.
> The idea is to use various atoms present in ref-filter to implement
> pretty format options.Yeah, I think that's a good idea.
> Valid atoms in ref-filter: > https://github.com/git/git/blob/master/ref-filter.c#L474-L520
[...]
Show 11 quoted lines
> ## Blogging about Git > > I have always been reluctant to articulate my opinions and broadcast > them to the world in any way. I have a long way to go as a writer, > thinker, and as a human being before my opinions on matters of > personal significance to me will be worth sharing. (Whoa! I have > opinions about my opinions! Ad infinitum!) > Having said that, I think GSoC and Git might be a great couple for > facilitating my first foray into technical blogging. And over the > course of the summer and beyond, I would love to write about my > progress and experiences contributing to Git.
Good. If it appears to be too much of a problem, it's ok to just send weekly email updates to the mailing list.