Re: [PATCH 2/2] submodule: port subcommand 'set-url' from shell to C

From: Christian Couder <christian.couder@gmail.com>
Date: Apr 17, 2020, 22:13 UTC
Message-ID: <CAP8UFD2c_QtS=KWY8rwqMOu1A-KLVE_3dfiCUopWT-W60gg8eA@mail.gmail.com>
In-Reply-To: <20200416210456.19122-3-shouryashukla.oo@gmail.com>

On Thu, Apr 16, 2020 at 11:05 PM Shourya Shukla <shouryashukla.oo@gmail.com> wrote:

> -       git submodule--helper config submodule."$name".url "$url"
> -       git submodule--helper sync ${GIT_QUIET:+--quiet} "$name"
> +       git ${wt_prefix:+-C "$wt_prefix"} ${prefix:+--super-prefix "$prefix"} submodule--helper set-url ${GIT_QUIET:+--quiet} -- "$@"

Maybe I missed something but I see nothing in the C code that does what the `git submodule--helper sync ...` call does. Maybe for now it would work better if that call was kept after the the call to `git ... submodule--helper set-url ...`