Re: [PATCH 0/6] bisect: follow-up fixes from js/bisect-in-c

From: Christian Couder <christian.couder@gmail.com>
Date: Dec 15, 2022, 10:45 UTC
Message-ID: <CAP8UFD2KT-GnBa1jGjXGc=bH_hQHhO9k0Qw6qBwmsXdsaHxnKA@mail.gmail.com>
In-Reply-To: <cover-0.6-00000000000-20221215T094038Z-avarab@gmail.com>

On Thu, Dec 15, 2022 at 11:27 AM Ævar Arnfjörð Bjarmason <avarab@gmail.com> wrote:

> This small set of fixes is a cherry-pick of various miscellanious

s/miscellanious/miscellaneous/

> fixes that were part of js/bisect-in-c that are still worth
> having.

Thanks! All the patches make sense and look good to me.

> Johannes Schindelin (5):
>   bisect--helper: simplify exit code computation
>   bisect: verify that a bogus option won't try to start a bisection
>   bisect run: fix the error message

I just noticed a nit in the commit message of the above patch. It contains:

"Fix that, and add a regression test to ensure that the intended form of the error message."

And it seems to me that something like "is printed" is missing from the end of that sentence.

Show 5 quoted lines

>   bisect: remove Cogito-related code
>   bisect: no longer try to clean up left-over `.git/head-name` files
>
> Ævar Arnfjörð Bjarmason (1):
>   bisect--helper: make the order consistently `argc, argv`