Re: [RFC PATCH 0/4] interpret-trailers: introduce "move" action

From: Christian Couder <christian.couder@gmail.com>
Date: Oct 6, 2017, 12:33 UTC
Message-ID: <CAP8UFD28vVx51xhDgQVesm356XAjfwb286baER-U6VOC+4NL4w@mail.gmail.com>
In-Reply-To: <748131b7-bddd-08c2-ff72-9fd1a63ef6a0@redhat.com>

On Fri, Oct 6, 2017 at 12:40 PM, Paolo Bonzini <pbonzini@redhat.com> wrote:

> On 06/10/2017 12:30, Christian Couder wrote:

Show 16 quoted lines

>> Did you try using `--where end --if-exists replace --trailer "$sob"`?
>
> Yes, it's a different behavior; "--if-exists replace" matches on others'
> SoB as well, so it would eat the original author's SoB if I didn't have one.
>
> So "move" does get it wrong for
>
>     Signed-off-by: Me
>     Signed-off-by: Friend
>
> (Me gets moved last, which may not be what you want) but "replace" gets
> it wrong in the arguably more common case of
>
>     Signed-off-by: Friend
>
> which is damaged to just "Signed-off-by: Me".

Ok. I think you might want something called for example "replaceIfIdenticalClose" where "IdenticalClose" means: "there is a trailer with the same (<token>, <value>) pair above or below the line where the replaced trailer will be put when ignoring trailers with a different <token>".