git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Use of uninitialised value of size 8 in sha1_name.c

From
Christian Couder <christian.couder@gmail.com>
Date
Feb 26, 2018, 09:04 UTC
Message-ID
<CAP8UFD23z9YDukO=O+cK=o_0DLcxbkXWzp4rCA1kRXGTZ-TMcQ@mail.gmail.com>
Hi Derrick,
These days when running:
./t5616-partial-clone.sh --valgrind
on master, I get a bunch of:

==21455== Use of uninitialised value of size 8 ==21455== at 0x2D2A73: get_hex_char_from_oid (sha1_name.c:492) ==21455== by 0x2D2AFE: extend_abbrev_len (sha1_name.c:502) ==21455== by 0x2D2C3D: find_abbrev_len_for_pack (sha1_name.c:551) ==21455== by 0x2D2CFF: find_abbrev_len_packed (sha1_name.c:569) ==21455== by 0x2D2E12: find_unique_abbrev_r (sha1_name.c:608) ==21455== by 0x2DCB66: strbuf_add_unique_abbrev (strbuf.c:877) ==21455== by 0x14F7CE: update_local_ref (fetch.c:700) ==21455== by 0x1500CF: store_updated_refs (fetch.c:871) ==21455== by 0x15035B: fetch_refs (fetch.c:932) ==21455== by 0x150CF8: do_fetch (fetch.c:1146) ==21455== by 0x1515AB: fetch_one (fetch.c:1370) ==21455== by 0x151A1D: cmd_fetch (fetch.c:1457) ==21455== Uninitialised value was created by a stack allocation ==21455== at 0x2D2B2E: find_abbrev_len_for_pack (sha1_name.c:513) ==21455==

A quick git blame seems to point to 0e87b85683 (sha1_name: minimize OID comparisons during disambiguation, 2017-10-12).

It is difficult to tell for sure though as t5616-partial-clone.sh was added after that commit.

Best, Christian.

Next: Jeff King
Message 1 of 14 in “Use of uninitialised value of size 8 in sha1_name.c”
  1. Christian CouderFeb 26, 2018
  2. Jeff KingFeb 26, 2018
  3. Christian CouderFeb 26, 2018
  4. Derrick StoleeFeb 26, 2018
  5. Christian CouderFeb 26, 2018
  6. sha1_name: fix uninitialized memory errorsDerrick Stolee, Feb 26, 2018
  7. Jeff KingFeb 26, 2018
  8. sha1_name: fix uninitialized memory errorsDerrick Stolee, Feb 27, 2018
  9. Jeff KingFeb 27, 2018
  10. Junio C HamanoFeb 27, 2018
  11. Jeff KingFeb 27, 2018
  12. Junio C HamanoFeb 28, 2018
  13. Derrick StoleeFeb 28, 2018
  14. Junio C HamanoFeb 28, 2018

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.