Re: [PATCH v2] trailer: load config to handle core.commentChar

From: Christian Couder <christian.couder@gmail.com>
Date: Apr 28, 2016, 21:06 UTC
Message-ID: <CAP8UFD20p7D3J05xKpYDviXxV8EZvLFhESMDhrmCPaT=bsRcDA@mail.gmail.com>
In-Reply-To: <1461873658-11394-1-git-send-email-rafalklys@wp.pl>

On Thu, Apr 28, 2016 at 10:00 PM, Rafal Klys <rafalklys@wp.pl> wrote:

Show 17 quoted lines

> Fall throught git_default_config when reading config to update the
> comment_line_char from default '#' to possible different value set in
> core.commentChar.
>
> Signed-off-by: Rafal Klys <rafalklys@wp.pl>
> ---
>
> Added fallthru instead of reading config third time.
>
> Added test, updated commit message.
>
> I even tried to change that to only one pass, but looks like it would require a
> bit more coding, so maybe next time.
>
> Thanks for feedback, I'm impressed that contributing to Git is so easy for
> newbies (never sent a patch via email before!) and that the response is so
> quick.

Thanks for contributing great patches and for the kind words! I am also happy that you find it easy for newbies to contribute.