Re: [PATCH v2] upload-pack: fix filter options scope

From

Christian Couder <christian.couder@gmail.com>

Date

May 8, 2020, 18:00 UTC

Message-ID

<CAP8UFD2-8FwEjyHromp-=MSSeFo=mn9GhkPvtFnF9MRx-4cjPQ@mail.gmail.com>

In-Reply-To

<20200508171635.GB637136@coredump.intra.peff.net>

On Fri, May 8, 2020 at 7:16 PM Jeff King <peff@peff.net> wrote:

>
> On Fri, May 08, 2020 at 08:46:58AM -0700, Junio C Hamano wrote:

> > Is it that the server side was incapable of serving a follow-up
> > fetch request in the same process when protocol v2 was in use?
> > Perhaps
> >
> >     upload-pack: allow follow-up fetch in protocol v2
> >
> > or something?
>
> Yeah, I agree that's better. Maybe even:
>
>   upload-pack: clear filter_options for each v2 fetch command

Ok, I will resend soon with the above title.

> which is more direct (we already allow follow-up fetches; they just
> don't work sometimes) and makes it clear that this is about fixing the
> filter feature with v2.