Re: [PATCH v2] upload-pack: use buffered I/O to talk to rev-list

From: Christian Couder <christian.couder@gmail.com>
Date: Aug 13, 2020, 05:17 UTC
Message-ID: <CAP8UFD1rDZOQSDWhc+xdEQVX+Umq-nE-sd-orgKZ3UWTWFHJhw@mail.gmail.com>
In-Reply-To: <cf395005-af63-f698-fe19-6c4b6f1a8a4b@web.de>

On Wed, Aug 12, 2020 at 6:54 PM René Scharfe <l.s.r@web.de> wrote:

Show 5 quoted lines

> -       close(cmd->in);
> +       if (ferror(cmd_in) || fflush(cmd_in))
> +               goto error;
> +       fclose(cmd_in);
>         cmd->in = -1;

I wonder if setting cmd->in to -1 is still useful...

Show 10 quoted lines

>         sigchain_pop(SIGPIPE);
>
> @@ -660,8 +658,8 @@ static int do_reachable_revlist(struct child_process *cmd,
>  error:
>         sigchain_pop(SIGPIPE);
>
> -       if (cmd->in >= 0)
> -               close(cmd->in);
> +       if (cmd_in)
> +               fclose(cmd_in);

...as we don't check cmd->in anymore at the end of the function, but we now check cmd_in instead. So should cmd_in have been set to -1 instead of cmd->in?