Re: [PATCH 0/2] [Outreachy] gpg-interface.c: use string_list_split instead of strbuf_split_max

From: Christian Couder <christian.couder@gmail.com>
Date: Oct 15, 2025, 15:40 UTC
Message-ID: <CAP8UFD1paGeMQZ6oOHau4YBiSC8U3csWHFdOx+ro-8xOO+0wTA@mail.gmail.com>
In-Reply-To: <cover.1760490943.git.belkid98@gmail.com>

On Wed, Oct 15, 2025 at 4:19 AM Olamide Caleb Bello <belkid98@gmail.com> wrote:

Show 7 quoted lines

>
> The array of strbufs that calls to strbuf_split_max provides are merely
> used to store the list of tokens gotten from the split and no edit are
> done on these resulting splits making the strbuf_split_max unideal
> for this usecase.
>
> This patchset replaces these instances with the modern string_list_split

A cover letter like this should be used to provide broad context for the changes. So if there are there patch series or merged commits that started doing something similar, it would be a good idea to mention them or give a link. (To properly mention a commit, you can use something like: `git show -s --pretty="tformat:%h (%s, %ad)" --date=short <commit>`.) If there are mailing list discussions were the topic was discussed, it could be interesting to mention and link them too.

Thanks.