Re: What's cooking in git.git (Nov 2023, #01; Thu, 2)

From: Christian Couder <christian.couder@gmail.com>
Date: Nov 3, 2023, 22:48 UTC
Message-ID: <CAP8UFD1fZX=0_odDWPAAU2VbZ5GNVYZgY31OPPGeQriSSweUqw@mail.gmail.com>
In-Reply-To: <xmqqa5rwo7u7.fsf@gitster.g>

On Thu, Nov 2, 2023 at 9:53 AM Junio C Hamano <gitster@pobox.com> wrote:

Show 14 quoted lines

> * ps/ci-gitlab (2023-11-02) 8 commits
>  - ci: add support for GitLab CI
>  - ci: install test dependencies for linux-musl
>  - ci: squelch warnings when testing with unusable Git repo
>  - ci: unify setup of some environment variables
>  - ci: split out logic to set up failed test artifacts
>  - ci: group installation of Docker dependencies
>  - ci: make grouping setup more generic
>  - ci: reorder definitions for grouping functions
>
>  Add support for GitLab CI.
>
>  Comments?
>  source: <cover.1698843660.git.ps@pks.im>

I just took a look at this series and I like both the idea of having a GitLab CI configuration in the code codebase and the implementation which makes things as easy as possible to maintain.

Show 22 quoted lines

> * cc/git-replay (2023-10-10) 14 commits
>  - replay: stop assuming replayed branches do not diverge
>  - replay: add --contained to rebase contained branches
>  - replay: add --advance or 'cherry-pick' mode
>  - replay: use standard revision ranges
>  - replay: make it a minimal server side command
>  - replay: remove HEAD related sanity check
>  - replay: remove progress and info output
>  - replay: add an important FIXME comment about gpg signing
>  - replay: change rev walking options
>  - replay: introduce pick_regular_commit()
>  - replay: die() instead of failing assert()
>  - replay: start using parse_options API
>  - replay: introduce new builtin
>  - t6429: remove switching aspects of fast-rebase
>
>  Introduce "git replay", a tool meant on the server side without
>  working tree to recreate a history.
>
>  Expectting a (hopefully final and quick) reroll.
>  cf. <bd872b81-80a9-5e4e-dcb6-faebc9671848@gmx.de>
>  source: <20231010123847.2777056-1-christian.couder@gmail.com>

Reroll sent yesterday (https://lore.kernel.org/git/20231102135151.843758-1-christian.couder@gmail.com/). A quick review of the latest changes would be nice.

Show 10 quoted lines

> * js/doc-unit-tests (2023-11-02) 3 commits
>  - ci: run unit tests in CI
>  - unit tests: add TAP unit test framework
>  - unit tests: add a project plan document
>  (this branch is used by js/doc-unit-tests-with-cmake.)
>
>  Process to add some form of low-level unit tests has started.
>
>  Will merge to 'next'?
>  source: <cover.1698881249.git.steadmon@google.com>

I just took a look at the v9 of the series and it looks good despite a small nit. Also I like the idea and implementation, so I agree with merging it to 'next' and then 'master'.