Re: [PATCH] t: make many tests depend less on the refs being files
- From
Christian Couder <christian.couder@gmail.com>
- Date
- May 23, 2018, 05:33 UTC
- Message-ID
- <CAP8UFD1c2oWd6SN+bWRmARnJCSmf+UuQpDWURxKYEwJyQ8oprA@mail.gmail.com>
- In-Reply-To
- <CAGZ79kbdVm-U16rMjtgnGL+TOVRqkZz+J5W_eqo=dh42xRgKBQ@mail.gmail.com>
On Mon, May 21, 2018 at 9:34 PM, Stefan Beller <sbeller@google.com> wrote:
Show 22 quoted lines
> On Sun, May 20, 2018 at 10:51 PM, Christian Couder > <christian.couder@gmail.com> wrote: >> From: David Turner <dturner@twopensource.com> >> >> So that they work under alternate ref storage backends. > > Sometimes I have a disconnect between the subject and the commit > message, (e.g. in an email reader the subject is not displayed accurately on > top of the message). > > So I would prefer if the first part of the body message is an actual > sentence, and > not a continuum from the subject. > > Maybe elaborate a bit more: > > The current tests are very focused on the file system representation of > the loose and packed refs code. As there are plans to implement other > ref storage systems, migrate most tests to a form that test the intent of the > refs storage system instead of it internals. The internals of the loose and > packed refs are tested in <TODO>, whereas the tests in this patch focus > on testing other aspects.
Thanks for this suggestion!
Show 5 quoted lines
>> This will be really needed when such alternate ref storage backends are >> developed. But this could already help by making clear to readers that >> some tests do not depend on which ref backend is used. > > Ah, this is what I picked up already in the suggested edit above. :/
I actually mixed parts of your suggested message with parts of the existing message in the V2 I just sent:
https://public-inbox.org/git/20180523052517.4443-1-chriscool@tuxfamily.org/