git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 0/3] [GSoC][Patch] area: t4202-log.sh, modernizing test script

From
Christian Couder <christian.couder@gmail.com>
Date
Apr 25, 2022, 09:45 UTC
Message-ID
<CAP8UFD1aAVCgEQvi4WjCiRUBWs6_u-7k-JWTz5b1N7xa=V8OdA@mail.gmail.com>
In-Reply-To
<BYAPR06MB4517BCBBA837AA3004B2137DE6F29@BYAPR06MB4517.namprd06.prod.outlook.com>
Hi,

On Tue, Apr 19, 2022 at 8:33 AM Jack McGuinness <jmcguinness2@ucmerced.edu> wrote:

>
> Hi, thank you for the advice. I wanted it to be that way myself, however I was using gitgitgadget to email it, and my PR was composed of three different commits, which caused it to automatically be formatted that way. I tried finding a way to remove it, but I had no luck, If you know how I would love to know!

I don't use gitgitgadget, so I cannot help you much on this. The approach I would take if I had to use it would be to find patches on the mailing list that were sent using gitgitgadget by experienced developers using it, then find and see how the corresponding PRs look like on GitHub, and try to imitate those PRs.

Anyway, it would be nice if you could try again taking into account Junio's suggestions in:

https://lore.kernel.org/git/xmqqmtggs2nv.fsf@gitster.g/
I also have some suggestions below.
> To: Jack McGuinness via GitGitGadget; git@vger.kernel.org
> Cc: Jack McGuinness
> Subject: Re: [PATCH 0/3] [GSoC][Patch] area: t4202-log.sh, modernizing test script

This is your second attempt so it would be nice if it had a "v2" marker in it like "[PATCH v2 0/3] [GSoC]" instead of "[PATCH 0/3] [GSoC][Patch]". (Your next attempt should use "v3".)

Show 5 quoted lines
> On 4/19/22 08:31, Jack McGuinness via GitGitGadget wrote:
> > Jack McGuinness (3):
> >   [GSoC][Patch] area: t4202-log.sh, modernizing test script
> >   [GSoC][Patch] area: t4202-log.sh, modernizing test script p2
> >   [GSoC][Patch] area: t4202-log.sh, modernizing test script p3

Junio already commented on the "area: t4202-log.sh" part of the subject, so I won't repeat him.

About the "modernizing test script ..." part, it would be nice if the different patches would be a bit more specific about what each one is doing and "p2" or "p3" is redundant with the "2/3" or "3/3" added by GitGitGadget. For example it could be replaced with "remove whitespace after redirect" for the second patch.

Previous: Jack McGuinness
Message 7 of 7 in “area: t4202-log.sh, modernizing test script”
  1. 0/3 [GSoC][Patch] area: t4202-log.sh, modernizing test scriptJack McGuinness via GitGitGadget, Apr 19, 2022
  2. 1/3 [GSoC][Patch] area: t4202-log.sh, modernizing test scriptJack McGuinness via GitGitGadget, Apr 19, 2022
  3. 2/3 [GSoC][Patch] area: t4202-log.sh, modernizing test script p2Jack McGuinness via GitGitGadget, Apr 19, 2022
  4. 3/3 [GSoC][Patch] area: t4202-log.sh, modernizing test script p3Jack McGuinness via GitGitGadget, Apr 19, 2022
  5. Bagas SanjayaApr 19, 2022
  6. Jack McGuinnessApr 19, 2022
  7. Christian CouderApr 25, 2022

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.