git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: Feature request: 'git bisect run' option to redundantly check start and end commits

From
Christian Couder <christian.couder@gmail.com>
Date
Dec 18, 2020, 16:16 UTC
Message-ID
<CAP8UFD1XMA7y6qXXS8h2HZXTuC8nGVkxTiMG3ZA54XJJg=gAsQ@mail.gmail.com>
In-Reply-To
<5fdccc25255b7_1273af2086c@natae.notmuch>

On Fri, Dec 18, 2020 at 4:39 PM Felipe Contreras <felipe.contreras@gmail.com> wrote:

Show 13 quoted lines
>
> Ed Avis wrote:
> > When kicking off a 'git bisect run', I have manually chosen good and
> > bad commits, but I would like to double check that the command given
> > to run really does succeed for the good commit and fail for the bad
> > one.  Of course I can switch to those commits and run it manually, but
> > mistakes can happen.  It's frustrating to set up a bisection and then
> > find at the end that the first bad commit is the one immediately after
> > 'good', because the command string just failed every time.  An
> > optional startup check of the two endpoints would only be a small
> > slowdown in most cases, but could save a lot of time.
>
> I like this idea.
I like this idea too.
Show 8 quoted lines
> I for one have to think twice if I should do the extra check manually or
> not, and the biggest reason why I usually don't is because it would not
> be automated.
>
> With an option like that I would have no excuse.
>
> Here's a quick patch to implement such feature (it doesn't apply
> directly, it's mostly for human eyes).

There has been a lot of work over the years to port code from shell in git-bisect.sh to C in builtin/bisect--helper.c. So it would be nice, if you plan to implement this feature, if you could do it directly in builtin/bisect--helper.c.

Thanks, Christian.

Previous: Felipe ContrerasNext: Felipe Contreras
Message 3 of 7 in “Feature request: 'git bisect run' option to redundantly check start and end commits”
  1. Ed AvisDec 18, 2020
  2. Felipe ContrerasDec 18, 2020
  3. Christian CouderDec 18, 2020
  4. Felipe ContrerasDec 18, 2020
  5. Christian CouderDec 19, 2020
  6. Felipe ContrerasDec 19, 2020
  7. Junio C HamanoDec 19, 2020

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.