git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 3/4] diff: change scope of the function count_lines()

From
Christian Couder <christian.couder@gmail.com>
Date
Jul 4, 2020, 21:46 UTC
Message-ID
<CAP8UFD1PZ=S401xUAiwcC4LJ+m-X0L2Lv6jQ84OfTZD4hP0K_w@mail.gmail.com>
In-Reply-To
<20200704152802.GA46571@konoha>

On Sat, Jul 4, 2020 at 5:28 PM Shourya Shukla <shouryashukla.oo@gmail.com> wrote:

>
> On 03/07 05:07, Johannes Schindelin wrote:
Show 8 quoted lines
> > In addition, as with all such changes, we need to be careful to consider
> > whether unrelated function names coming in from system headers might
> > clash. In this case, I think `count_lines()` is a bit too generic, but
> > will probably not clash. Personally, I would probably have opted for
> > `count_lines_in_string()`.
>
> I do not see it clashing with any other functions. Do we need to change
> the name still (maybe to make the functions purpose even more clear)?

This patch might not be needed at all according to Dscho's review of another patch in this series.

Previous: Shourya ShuklaNext: Shourya Shukla
Message 12 of 21 in “submodule: port 'summary' from Shell to C”
  1. Shourya ShuklaJul 2, 2020
  2. 1/4 submodule: amend extra line feed between callback struct and macroShourya Shukla, Jul 2, 2020
  3. Johannes SchindelinJul 3, 2020
  4. Philip OakleyJul 3, 2020
  5. Shourya ShuklaJul 4, 2020
  6. Đoàn Trần Công DanhJul 4, 2020
  7. Philip OakleyJul 5, 2020
  8. 2/4 submodule: rename helper functions to avoid ambiguityShourya Shukla, Jul 2, 2020
  9. 3/4 diff: change scope of the function count_lines()Shourya Shukla, Jul 2, 2020
  10. Johannes SchindelinJul 3, 2020
  11. Shourya ShuklaJul 4, 2020
  12. Christian CouderJul 4, 2020
  13. 4/4 submodule: port submodule subcommand 'summary' from shell to CShourya Shukla, Jul 2, 2020
  14. Johannes SchindelinJul 3, 2020
  15. Shourya ShuklaJul 5, 2020
  16. Kaartic SivaraamJul 6, 2020
  17. Shourya ShuklaJul 6, 2020
  18. Johannes SchindelinJul 12, 2020
  19. Shourya ShuklaJul 15, 2020
  20. Shourya ShuklaJul 15, 2020
  21. Johannes SchindelinAug 10, 2020

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.