Re: "git bisect" takes exactly one bad commit and one or more good?

From: Christian Couder <christian.couder@gmail.com>
Date: Nov 11, 2017, 12:01 UTC
Message-ID: <CAP8UFD1=idL51XDzE_RKc_7z9NghTd7GHoZ-T61y0rQ8ZYXomw@mail.gmail.com>
In-Reply-To: <alpine.LFD.2.21.1711110612290.5087@localhost.localdomain>

On Sat, Nov 11, 2017 at 12:22 PM, Robert P. J. Day <rpjday@crashcourse.ca> wrote:

>
>   more on "git bisect" ... the man page seems to make it clear that
> bisection takes *precisely* one "bad" commit, and one *or more* good
> commits, is that correct?

Yeah, that's true.

Show 7 quoted lines

> seems that way, given the ellipses in the
> commands below:
>
>   git bisect start [--term-{old,good}=<term> --term-{new,bad}=<term>]
>                    [--no-checkout] [<bad> [<good>...]] [--] [<paths>...]
>   git bisect (bad|new|<term-new>) [<rev>]
>   git bisect (good|old|<term-old>) [<rev>...]

Yeah indeed.

Show 6 quoted lines

> however, other parts of the man page seem less clear. just below
> that, a description that bisection takes "a" good commit:
>
> "You use it by first telling it a "bad" commit that is known to
> contain the bug, and a "good" commit that is known to be before the
> bug was introduced."

Yeah, 'and at least a "good" commit' would be better.

Show 6 quoted lines

> and a bit lower, we read "at least one bad ...", which some people
> might interpret as one or more *bad* commits:
>
> "Once you have specified at least one bad and one good commit, git
> bisect selects a commit in the middle of that range of history, checks
> it out, and outputs something similar to the following:"

Yeah, 'Once you have specified one bad and at least one good commit' would be better.

>   if the rules are exactly one bad commit and one or more good, i'll
> submit a patch to reword at least the above, and possibly more if
> necessary.

Sure, thanks, Christian.