Re: [RFC][Outreachy] Seeking Git Community Feedback on My Application

From: Christian Couder <christian.couder@gmail.com>
Date: Oct 28, 2023, 12:37 UTC
Message-ID: <CAP8UFD1+aWGymjssk5CotPjEmhu5sMcTy-b7eJc4fw-UA41Qig@mail.gmail.com>
In-Reply-To: <CAJHH8bGK28Fc+VG3uxgC5sGgFEAw6_6AEtusgmw7c4Vz0iGF_g@mail.gmail.com>

On Sat, Oct 28, 2023 at 12:41 PM Isoken Ibizugbe <isokenjune@gmail.com> wrote:

>
> On Sat, Oct 28, 2023 at 9:07 AM Christian Couder
> <christian.couder@gmail.com> wrote:

Show 16 quoted lines

> > > #define DIGIT "0123456789"
> > >
> > > static void t_digit_type(void)
> > > {
> > >     int i;
> > >     const char *digits = DIGIT;
> > >     for (i = 0; digits[i]; i++)
> > >    {
> > >          check_int(isdigit(digits[i]), ==, 0);
> > >    }
> >
> > This tests that isdigit() returns 0 for each of the characters in
> > "0123456789", but first I think isdigit() should return 1, not 0 for
> > those characters.
>
> yes, that is true. should I send a re-roll?

Yes, please.