Re: [PATCH v2] MyFirstContribution: add note on confirming patches

From: Christian Couder <christian.couder@gmail.com>
Date: Oct 27, 2025, 08:45 UTC
Message-ID: <CAP8UFD0rMxdLN3TY3EACXHG6x40OPy-WYpbhPLx=ouk=6z7LZw@mail.gmail.com>
In-Reply-To: <20251024210433.2033-1-qjessa662@gmail.com>

On Fri, Oct 24, 2025 at 11:04 PM QueenJcloud <qjessa662@gmail.com> wrote:

Show 6 quoted lines

>
> Add a note after the `git send-email` section explaining how
> contributors can confirm that their patches reached the mailing
> list by checking https://lore.kernel.org/git/.
>
> Signed-off-by: QueenJcloud <qjessa662@gmail.com>

Are you sure that "QueenJcloud" is the best way to identify you? We prefer a real name if possible, and yeah it should match the name associated with your email address.

Documentation/SubmittingPatches has the following about this:

"[[real-name]] Please use a known identity in the `Signed-off-by` trailer, since we cannot accept anonymous contributions. It is common, but not required, to use some form of your real name. We realize that some contributors are not comfortable doing so or prefer to contribute under a pseudonym or preferred name and we can accept your patch either way, as long as the name and email you use are distinctive, identifying, and not misleading.

The goal of this policy is to allow us to have sufficient information to contact you if questions arise about your contribution."

> ---

This is a v2 patch, so it would be nice to know what changed since the previous version of the patch. It could be added here after the line with three dashes ("---").

Also it looks like this v2 patch was sent twice.

Show 15 quoted lines

>  Documentation/MyFirstContribution.adoc | 6 ++++++
>  1 file changed, 6 insertions(+)
>
> diff --git a/Documentation/MyFirstContribution.adoc b/Documentation/MyFirstContribution.adoc
> index 02ba8ba5f6..6e7f3036bb 100644
> --- a/Documentation/MyFirstContribution.adoc
> +++ b/Documentation/MyFirstContribution.adoc
> @@ -1153,11 +1153,17 @@ NOTE: When you are sending a real patch, it will go to git@vger.kernel.org - but
>  please don't send your patchset from the tutorial to the real mailing list! For
>  now, you can send it to yourself, to make sure you understand how it will look.
>
> +NOTE: After sending your patches, you can confirm that they reached the mailing
> +list by visiting https://lore.kernel.org/git/. Use the search bar to find your
> +name or the subject of your patch. If it appears, your email was successfully
> +delivered.

This looks good to me.

Show 6 quoted lines

>  After you run the command above, you will be presented with an interactive
>  prompt for each patch that's about to go out. This gives you one last chance to
>  edit or quit sending something (but again, don't edit code this way). Once you
>  press `y` or `a` at these prompts your emails will be sent! Congratulations!
>
> +

It looks like there is a spurious new line here. Please remove it.

>  Awesome, now the community will drop everything and review your changes. (Just
>  kidding - be patient!)

Thanks.