Re: [PATCH 0/2] split index extra bits

From: Christian Couder <christian.couder@gmail.com>
Date: May 8, 2017, 06:40 UTC
Message-ID: <CAP8UFD0r06gX1QE+hsSAN6uGvNfQJgUv1PmbzoQyAg7_FpHiGQ@mail.gmail.com>
In-Reply-To: <xmqqk25sazik.fsf@gitster.mtv.corp.google.com>

On Mon, May 8, 2017 at 3:49 AM, Junio C Hamano <gitster@pobox.com> wrote:

Show 10 quoted lines

> Junio C Hamano <gitster@pobox.com> writes:
>
>> Christian Couder <christian.couder@gmail.com> writes:
>>
>>> This patch series contains 2 patches that have already been sent to
>>> the list but have felt through the cracks. It would be nice if they
>>> could be considered for v2.13.0.
>>
>> There is no way for anything new to go to 2.13 without getting
>> reviewed and discussed at this point---it simply is way too late.

Ok, sorry about resending too late.

Show 9 quoted lines

> I found that this is <20170419093314.4454-1-pclouds@gmail.com> in
> mid April (please do not make readers dig the list archive when you
> can).
>
> I didn't see anybody (not even you, to whom the patch was apparently
> addressed) commenting back then on the patch and that was why I
> didn't touch it.  I've skimmed the change in 1/2 now, and although I
> didn't see anything glaringly wrong, it would be good to have a test
> if this fixes a reproducible crash.

It fixes a memory leak not a crash. And this should not be a big problem as shared index files should not be changed often in the same Git process.