Re: [RFC PATCH 05/10] pack-bitmap: don't rely on bitmap_git->reuse_objects

From: Christian Couder <christian.couder@gmail.com>
Date: Oct 11, 2019, 07:50 UTC
Message-ID: <CAP8UFD0mZgN5=Bva6drLoAusMTomTZ9X=jRCeGgrTBK-mxCBLw@mail.gmail.com>
In-Reply-To: <20191010234408.170356-1-jonathantanmy@google.com>

On Fri, Oct 11, 2019 at 1:44 AM Jonathan Tan <jonathantanmy@google.com> wrote:

Show 12 quoted lines

>
> > As we now allocate 2 more words than necessary for each
> > bitmap to serve as marks telling us that we can stop
> > iterating over the words, we don't need to rely on
> > bitmap_git->reuse_objects to stop iterating over the words.
>
> As Peff states [1], this justification is probably incorrect as well.
> The actual justification seems to be that we will no longer compute
> reuse_objects (in a future patch), so we cannot rely on it anymore to
> terminate the loop early; we have to iterate to the end.
>
> [1] https://public-inbox.org/git/20191002155721.GD6116@sigill.intra.peff.net/

Ok, thanks! I will change the description.