Re: Found possible branch point, then "Use of uninitialized value $u in substitution/concatenation"
- From
Christian Couder <christian.couder@gmail.com>
- Date
- May 6, 2016, 08:27 UTC
- Message-ID
- <CAP8UFD0k0Kx306S3y-Kd5328j0MDNL+ewCJvXbsJ1nzsJYRdtg@mail.gmail.com>
- In-Reply-To
- <CALZdSA_pDy=B-bgB-vjpi1yjgtse_-07ewXSX0_GsYhLfOUbzw@mail.gmail.com>
Hi,
On Thu, May 5, 2016 at 12:43 PM, Thierry Suzanne <thierry@yellownemo.com> wrote:
Show 18 quoted lines
>
> Looking at svn.pm, I can see we're in find_parent_branch() which
> outputs the message "Found possible branch point". It then calls
> other_gs($new_url, $url, $branch_from, $r, $self->{ref_id});
>
> which itself calls:
> Git::SVN->find_by_url($new_url, $url, $branch_from);
>
> which calls:
> resolve_local_globs($u, $fetch, $globspec);
>
> and resolve_local_globs is where the error is thrown on line 100/101:
> my $u = (::cmt_metadata("$refname"))[0];
> $u =~ s!^\Q$url\E(/|$)!! or die
>
> I made a mistake in my command line for sure, so this might not be a
> bug, I'm just emailing all this if someone think it could be handled
> differently or a better error shown.Yeah, there is a die() calls above and also one on line 101, so it looks like $u could be checked between line 100 and line 101 and die() could be called if it is not properly defined.
Could you send a patch to do something like that?
Thanks, Christian.