Re: GSoC git-add--interactive improvements

From: Christian Couder <christian.couder@gmail.com>
Date: Apr 4, 2012, 08:26 UTC
Message-ID: <CAP8UFD0V17Gag3esFd=ZDocZZoiN_4a1bjQ8rFwbBZoJEiasBA@mail.gmail.com>
In-Reply-To: <4F7BC8FE.4060808@gmail.com>

Hi,

On Wed, Apr 4, 2012 at 6:07 AM, Corey F <coyotebush22@gmail.com> wrote:

Show 15 quoted lines

> Hi all,
>
> I'd be interested in making improvements to the git add -p (etc.) interface
> as a Google Summer of Code project, as suggested on the ideas page [1].
>
> The page lists some interesting ideas for both larger architectural changes
> and smaller interface improvements, though I agree that getting lots of
> community input during the project will be important. So at this point I'm
> wondering how much I should plan out in my proposal -- maybe pin down a few
> important features and a process for getting more input?
>
> Last year's SoC ideas page included rewriting some commands in C, including
> this one. I'm at least as comfortable with C as with Perl, but I'm guessing
> that incorporating a rewrite into the project would be an ambitious and/or
> dangerous idea.

It depends how you plan to do it. In builtin/apply.c and perhaps elsewhere there is already some C code that is duplicated in git-add--interactive.perl. Maybe you can first make add--interactive use the C code by creating a helper command and then move more and more stuff from add--interactive to the helper command. Hopefully in the end the code in the helper could be used to add an interactive mode to git apply.

Thanks, Christian.

PS: Sorry I replied to you only first.