Re: What's cooking in git.git (Jan 2018, #02; Tue, 9)

From: Christian Couder <christian.couder@gmail.com>
Date: Jan 18, 2018, 08:56 UTC
Message-ID: <CAP8UFD0P7kVo2NP4Wq7OaSV4H1+sqHapuzW5AQef+enNS0S5hw@mail.gmail.com>
In-Reply-To: <bda13f22-b6ca-f46d-9730-ff00ec536b0b@jeffhostetler.com>

On Wed, Jan 10, 2018 at 11:03 PM, Jeff Hostetler <git@jeffhostetler.com> wrote:

Show 26 quoted lines

>
>
> On 1/10/2018 2:57 PM, Junio C Hamano wrote:
>>
>> Jeff Hostetler <git@jeffhostetler.com> writes:
>>
>>> On 1/9/2018 6:33 PM, Junio C Hamano wrote:
>>>>
>>>> --------------------------------------------------
>>>> [Cooking]
>>>>
>>>>
>>>> * jh/fsck-promisors (2017-12-08) 10 commits
>>>
>>> [...]
>>>
>>>> * jh/partial-clone (2017-12-08) 13 commits
>>>
>>> [...]
>>>
>>> Parts 2 and 3 of partial clone have been simmering
>>> for a while now.  I was wondering if there were any
>>> more comments or questions on them.  I don't recall
>>> any existing issues.
>>
>> Me neither.

I am still not very happy with fetch_object() not returning anything. I wonder what happens when that function is used to fetch from a repo that cannot provide the requested object.

Also I think the "extensions.partialclone = <remote>" config option is not very future proof. If people start using partial clone, it is likely that at some point they will need their repo to talk to more than one remote that is partial clone enabled and I don't see how such a config option can scale in this case.

Show 8 quoted lines

>> I do not mind merging them to 'next' during the feature freeze, but
>> we won't be merging them to 'master' soon anyway, and I'd like to
>> see us concentrate more on finding and fixing regressions on the
>> 'master' front for now.
>
> I didn't want to rush this -- just check to see if there was
> any thing that I should focus on while waiting for 2.16 to ship
> and settle down.

Thanks for already having commented on the patch series I sent to integrate the external odb with the above work, Christian.