Re: [PATCH 01/40] Add initial external odb support
- From
Christian Couder <christian.couder@gmail.com>
- Date
- Jan 15, 2018, 14:34 UTC
- Message-ID
- <CAP8UFD0L5UFg5NgvfY84VnHsJZr9iq=R5d_+ZvGBEJw2NouJpA@mail.gmail.com>
- In-Reply-To
- <96c60f40-052c-b098-f58f-e39e308694f0@jeffhostetler.com>
On Thu, Jan 4, 2018 at 8:59 PM, Jeff Hostetler <git@jeffhostetler.com> wrote:
Show 19 quoted lines
>
>> diff --git a/odb-helper.h b/odb-helper.h
>> new file mode 100644
>> index 0000000000..9395e606ce
>> --- /dev/null
>> +++ b/odb-helper.h
>> @@ -0,0 +1,24 @@
>> +#ifndef ODB_HELPER_H
>> +#define ODB_HELPER_H
>> +
>> +struct odb_helper {
>> + const char *name;
>> + const char *dealer;
>> +
>> + struct odb_helper_object {
>> + unsigned char sha1[20];
>
>
> Should this be "struct object_id" ?Yeah, I changed this in my current version.
I cannot change all the functions to take a struct object_id though as some are called inside sha1_file.c where there are only sha1.