git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] t2080: fix cp invocation to copy symlinks instead of following them

From
Christian Couder <christian.couder@gmail.com>
Date
May 27, 2021, 07:25 UTC
Message-ID
<CAP8UFD0DoG5MR3V0eoy5LLf6mRBnthZMKjdmOiS8rhCQWRxoZw@mail.gmail.com>
In-Reply-To
<5386ee606567248464d39c313ee6177862a1f337.1622071475.git.matheus.bernardino@usp.br>

Just a few nits that you can take into account if you reroll the patch for another reason, but I am not sure they are worth rerolling by themselves.

On Thu, May 27, 2021 at 3:27 AM Matheus Tavares <matheus.bernardino@usp.br> wrote:

Show 10 quoted lines
>
> t2080 makes a few copies of a test repository and later performs a
> branch switch on each one of the copies to verify that parallel checkout
> and sequential checkout produce the same results. However, the
> repository is copied with `cp -R` which, on some systems, defaults to
> following symlinks on the directory hierarchy and copying their target
> files instead of copying the symlinks themselves. AIX is one example of
> system where this happens. Because the symlinks are not preserved, the
> copied repositories have paths that do not match what is in the index,
> causing git to abort the checkout operation that we want to test. This
s/git/Git/
Show 6 quoted lines
> makes the test fail on these systems.
>
> Fix this by copying the repository with the POSIX flag '-P', which
> forces cp to copy the symlinks instead of following them. Note that we
> already use this flag for other cp invocations in our test suite (see
> t7001).

Maybe you could mention 00764ca10e (test: fix t7001 cp to use POSIX options, 2014-04-11) that also fixed t7001 in a similar way.

> With this change, t2080 now passes on AIX.
Thanks!
Previous: Matheus TavaresNext: Ævar Arnfjörð Bjarmason
Message 2 of 15 in “t2080: fix cp invocation to copy symlinks instead of following them”
  1. t2080: fix cp invocation to copy symlinks instead of following themMatheus Tavares, May 26, 2021
  2. Christian CouderMay 27, 2021
  3. Ævar Arnfjörð BjarmasonMay 27, 2021
  4. Ævar Arnfjörð BjarmasonMay 31, 2021
  5. Matheus TavaresMay 31, 2021
  6. Ævar Arnfjörð BjarmasonMay 31, 2021
  7. Đoàn Trần Công DanhJun 2, 2021
  8. Ævar Arnfjörð BjarmasonJun 2, 2021
  9. Bagas SanjayaJun 2, 2021
  10. Đoàn Trần Công DanhJun 2, 2021
  11. Ævar Arnfjörð BjarmasonJun 2, 2021
  12. Đoàn Trần Công DanhJun 2, 2021
  13. Đoàn Trần Công DanhJun 3, 2021
  14. Torsten BögershausenJun 2, 2021
  15. brian m. carlsonJun 3, 2021

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.